]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
grabHelper: Consider events that release the grab handled
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 22 Mar 2013 18:21:04 +0000 (19:21 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 25 Mar 2013 09:43:29 +0000 (10:43 +0100)
Currently, if a button-press event results in releasing the last modal
grab (e.g. clicks outside the grabbed actors), we don't consider the
event handled and allow its emission to continue. If we consider
dismissing a grab as an action of its own, any additional action
triggered by the same event becomes an unexpected side effect.
Tweak the capture handler accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=696422

js/ui/grabHelper.js

index 0eed19bd477694a9b7111acb9b3678729f057a47..9f1374ed7c66f03a59bbd752ef288194b3adb732 100644 (file)
@@ -355,6 +355,7 @@ const GrabHelper = new Lang.Class({
                 this._ignoreRelease = true;
             let i = this._actorInGrabStack(event.get_source()) + 1;
             this.ungrab({ actor: this._grabStack[i].actor, isUser: true });
+            return true;
         }
 
         return this._modalCount > 0;